Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved examples #123

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Improved examples #123

merged 3 commits into from
Mar 5, 2020

Conversation

iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Mar 4, 2020

References to other Issues or PRs or Relevant literature

Fixes #112

Brief description of what is fixed or changed

Improved examples in PyDataStructs by changing print() to str()

Other comments

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   98.019%   98.019%           
=========================================
  Files           20        20           
  Lines         1363      1363           
=========================================
  Hits          1336      1336           
  Misses          27        27
Impacted Files Coverage Δ
...datastructs/linear_data_structures/linked_lists.py 100% <ø> (ø) ⬆️

Impacted file tree graph

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@iamrajiv
Copy link
Contributor Author

iamrajiv commented Mar 4, 2020

@czgdp1807 I have made changes to linked_list.py and other parts of the codebase is already changed like in stack.py, binary_trees.py, heaps.py, space_partitioning_trees.py and queue.py though it does not have function to return the contents of queue so what about adding function to return the contents of queue?

@czgdp1807
Copy link
Member

so what about adding function to return the contents of queue?

Can you please elaborate on what you actually want to do?

@czgdp1807 czgdp1807 added the documentation Improvements or additions to documentation label Mar 4, 2020
@iamrajiv
Copy link
Contributor Author

iamrajiv commented Mar 4, 2020

@czgdp1807 I have checked other parts of the codebase i.e. stack.py, binary_trees.py, heaps.py, space_partitioning_trees.py and str() is already been implemented in examples but in case of queue.py there is no function to return the contents of the queue so is it good to add function to return the contents of queue?

@czgdp1807
Copy link
Member

str() is already been implemented in examples but in case of queue.py there is no function to return the contents of the queue so is it good to add function to return the contents of queue?

Looks like a nice idea. Please make a separate PR for adding str method.

@czgdp1807 czgdp1807 merged commit 807f07e into codezonediitj:master Mar 5, 2020
@iamrajiv iamrajiv changed the title [WIP] Improved examples Improved examples Mar 5, 2020
@iamrajiv iamrajiv deleted the issue_112 branch March 5, 2020 10:11
@iamrajiv iamrajiv restored the issue_112 branch March 5, 2020 10:22
@iamrajiv iamrajiv deleted the issue_112 branch March 5, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve examples
2 participants