Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation for M-ary tree #140

Merged
merged 7 commits into from
Mar 18, 2020

Conversation

vibhu18116
Copy link
Contributor

Added M_aryTreeNode for use in M_ary tree and an implementation for
M_ary Tree. The work is in reference with issue #101.

Added M_aryTreeNode for use in M_ary tree and an implementation for
M_ary Tree. The work is in reference with issue codezonediitj#101.
@czgdp1807
Copy link
Member

Trailing white spaces can be removed by configuring your editor. For VSCode you may refer, https://marketplace.visualstudio.com/items?itemName=shardulm94.trailing-spaces

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #140 into master will decrease coverage by 1.444%.
The diff coverage is 36.170%.

@@              Coverage Diff              @@
##            master      #140       +/-   ##
=============================================
- Coverage   98.179%   96.735%   -1.445%     
=============================================
  Files           21        23        +2     
  Lines         1593      1746      +153     
=============================================
+ Hits          1564      1689      +125     
- Misses          29        57       +28     
Impacted Files Coverage Δ
pydatastructs/utils/__init__.py 100.000% <ø> (ø)
pydatastructs/utils/misc_util.py 88.888% <30.769%> (-8.548%) ⬇️
pydatastructs/trees/m_ary_trees.py 34.375% <34.375%> (ø)
pydatastructs/trees/__init__.py 100.000% <100.000%> (ø)
pydatastructs/graphs/graph.py 100.000% <0.000%> (ø)
pydatastructs/graphs/__init__.py 100.000% <0.000%> (ø)
pydatastructs/graphs/algorithms.py 100.000% <0.000%> (ø)
pydatastructs/graphs/adjacency_list.py 100.000% <0.000%> (ø)
pydatastructs/graphs/adjacency_matrix.py 100.000% <0.000%> (ø)
... and 7 more

Impacted file tree graph

@czgdp1807
Copy link
Member

This PR doesn't need unit tests as they will be added when m-ary search trees will be added.

@czgdp1807
Copy link
Member

Looks like we need some changes in the API of BinaryTree. I will open an issue for it shortly.

@vibhu18116
Copy link
Contributor Author

I don't see which files are causing the Travis to break. Can you please help out with this?

@HarsheetKakar
Copy link
Contributor

I don't see which files are causing the Travis to break. Can you please help out with this?

Try running tests in vs code. It will tell you the file name and the line number which is having tab spaces in it.

@czgdp1807
Copy link
Member

It's because tabs are being used for indentation. Please see the logs at https://travis-ci.org/github/codezonediitj/pydatastructs/builds/662786370?utm_source=github_status&utm_medium=notification

@vibhu18116
Copy link
Contributor Author

It shows line number 69 in file test_code_quality.py. However, I have not edited and committed this file at all.

@vibhu18116
Copy link
Contributor Author

If you suggest, I can reset my working branch with the pydatastructs/master and then push again after making necessary changes. It might sort out the issue.

@czgdp1807
Copy link
Member

The problem is with the following line,

E                   AssertionError: Tab present at 	MAryTreeNode, MAryTree
E                      in /home/czgdp1807ssd/codezonediitj/pydatastructs/pydatastructs/trees/__init__.py. Configure your editor to use white spaces.

Acutally I didn't supply %(line, file_path). Therefore the problem wasn't visible. I am making a PR to fix it. Will restart the tests so that it's visible on Travis CI.

@czgdp1807
Copy link
Member

Merging. Test coverage will reduce a bit. Adding MArySearchTree will fix that thing.

@czgdp1807 czgdp1807 merged commit eadae21 into codezonediitj:master Mar 18, 2020
@czgdp1807
Copy link
Member

@vibhu18116
Reminder
I hope that your team is able to find coaches for completing the application process for RGSoC, 2020. If not then please feel free to send invites to me and Vedansh Priyadarshi as the deadline for application is quite near.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants