Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation for Splay Trees. #157

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

Vanshika266
Copy link
Contributor

@Vanshika266 Vanshika266 commented Mar 15, 2020

Added code for splay trees with public APIs insert, delete, splay. The work is in reference with issue #109

@HarsheetKakar
Copy link
Contributor

files have trailing whitespaces in it. If you are using vs code, there is an option to remove trailing whitespaces on save.

Reference

https://stackoverflow.com/questions/30884131/remove-trailing-spaces-automatically-or-with-a-shortcut

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #157 into master will decrease coverage by 0.041%.
The diff coverage is 96.103%.

@@              Coverage Diff              @@
##            master      #157       +/-   ##
=============================================
- Coverage   98.578%   98.536%   -0.042%     
=============================================
  Files           24        24               
  Lines         2110      2187       +77     
=============================================
+ Hits          2080      2155       +75     
- Misses          30        32        +2     
Impacted Files Coverage Δ
pydatastructs/trees/__init__.py 100.000% <ø> (ø)
pydatastructs/trees/binary_trees.py 97.033% <96.103%> (+0.057%) ⬆️

Impacted file tree graph

@HarsheetKakar
Copy link
Contributor

adding tests will increase coverage.
https://codecov.io/gh/codezonediitj/pydatastructs/pull/157/diff the lines with red markings dont have tests

@czgdp1807
Copy link
Member

@Vanshika266 I hope that you are aware that official coding period of RGSoC, 2020 starts from July. Till 31st March you have to submit your application on RGSoC website. See, https://railsgirlssummerofcode.org/students/application/#apply for steps of applying.

@Vanshika266
Copy link
Contributor Author

@Vanshika266 I hope that you are aware that official coding period of RGSoC, 2020 starts from July. Till 31st March you have to submit your application on RGSoC website. See, https://railsgirlssummerofcode.org/students/application/#apply for steps of applying.

Yes, I will start working on the application.

@czgdp1807
Copy link
Member

@Vanshika266 Before adding implementation for join and split methods, I'd suggest to test whether the changes made in #176 works correctly or not. Please add tests for insert and delete. You can take examples from wikipedia and add tests on the basis of those examples.

@czgdp1807
Copy link
Member

@Vanshika266
Reminder
I hope that your team is able to find coaches for completing the application process for RGSoC, 2020. If not then please feel free to send invites to me and Vedansh Priyadarshi as the deadline for application is quite near.

@Vanshika266
Copy link
Contributor Author

@Vanshika266 Before adding implementation for join and split methods, I'd suggest to test whether the changes made in #176 works correctly or not. Please add tests for insert and delete. You can take examples from wikipedia and add tests on the basis of those examples.

I have added tests for insert, delete, split and join methods in SplayTree.
Can you review the tests once to see if it works ?

@czgdp1807
Copy link
Member

Coverage is low. More tests are needed for the lines marked in red in this page.

@czgdp1807
Copy link
Member

Any updates?

@Vanshika266
Copy link
Contributor Author

Sorry, pushed these commits by mistake. Fixing it.

@Vanshika266
Copy link
Contributor Author

Any updates?

Sorry for the delay. I have updated the implementation of SplayTree. I have removed the function split_array, and have now used the implementation of pre-order traversal from BinaryTreeTraversal Class.
Can you review the implementation once ?

@czgdp1807

This comment has been minimized.

@czgdp1807 czgdp1807 merged commit ffc9cf9 into codezonediitj:master Apr 8, 2020
@czgdp1807
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants