Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelfBalancingTree updated #189

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

HarsheetKakar
Copy link
Contributor

References to other Issues or PRs or Relevant literature

root_idx was not updating after #176

Brief description of what is fixed or changed

Other comments

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #189 into master will increase coverage by 0.034%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #189       +/-   ##
=============================================
+ Coverage   96.829%   96.864%   +0.034%     
=============================================
  Files           24        24               
  Lines         1798      1818       +20     
=============================================
+ Hits          1741      1761       +20     
  Misses          57        57               
Impacted Files Coverage Δ
pydatastructs/trees/binary_trees.py 96.951% <100.000%> (ø)
pydatastructs/graphs/__init__.py 100.000% <0.000%> (ø)
pydatastructs/graphs/algorithms.py 100.000% <0.000%> (ø)
pydatastructs/linear_data_structures/arrays.py 100.000% <0.000%> (ø)
pydatastructs/linear_data_structures/algorithms.py 100.000% <0.000%> (ø)

Impacted file tree graph

@HarsheetKakar
Copy link
Contributor Author

@czgdp1807 please check it.

@czgdp1807
Copy link
Member

It isn't really making any big difference for the current code. So merging.

@czgdp1807 czgdp1807 merged commit e4c78bf into codezonediitj:master Mar 22, 2020
@czgdp1807
Copy link
Member

The idea of introducing SelfBalancingTree is fine, so we will not be reverting that in any case. All the rotation methods should reside under that class.

@HarsheetKakar HarsheetKakar deleted the SelfBalancingTree branch March 22, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants