-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heaps.py supports list, tuple and pydatastructs.Array #218
Conversation
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=============================================
+ Coverage 96.937% 98.564% +1.627%
=============================================
Files 24 24
Lines 1959 2090 +131
=============================================
+ Hits 1899 2060 +161
+ Misses 60 30 -30
|
@czgdp1807 please check this one too |
This highlights a potential flaw. Will look more into it before commenting further. |
are you working on it yourself or shall I raise an issue listing all the problems with array.py? |
That was lame, I'm so sorry that I didn't figure it out on my own. Thanks for helping me out. |
Originally in the doctstring it was written that heap expects list/tuple but it was actually taking DODA, so I have made changes to accept list, tuple and Array and derivative objects.
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
Other comments