Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heaps.py supports list, tuple and pydatastructs.Array #218

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

HarsheetKakar
Copy link
Contributor

Originally in the doctstring it was written that heap expects list/tuple but it was actually taking DODA, so I have made changes to accept list, tuple and Array and derivative objects.

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #218 into master will increase coverage by 1.627%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #218       +/-   ##
=============================================
+ Coverage   96.937%   98.564%   +1.627%     
=============================================
  Files           24        24               
  Lines         1959      2090      +131     
=============================================
+ Hits          1899      2060      +161     
+ Misses          60        30       -30     
Impacted Files Coverage Δ
pydatastructs/trees/heaps.py 97.837% <100.000%> (+0.035%) ⬆️
pydatastructs/graphs/__init__.py 100.000% <0.000%> (ø)
pydatastructs/graphs/algorithms.py 100.000% <0.000%> (ø)
pydatastructs/graphs/adjacency_list.py 100.000% <0.000%> (ø)
pydatastructs/graphs/adjacency_matrix.py 100.000% <0.000%> (ø)
pydatastructs/linear_data_structures/__init__.py 100.000% <0.000%> (ø)
pydatastructs/linear_data_structures/algorithms.py 100.000% <0.000%> (ø)
...datastructs/linear_data_structures/linked_lists.py 99.613% <0.000%> (+0.006%) ⬆️
...datastructs/miscellaneous_data_structures/queue.py 100.000% <0.000%> (+1.333%) ⬆️
pydatastructs/utils/misc_util.py 100.000% <0.000%> (+9.259%) ⬆️
... and 1 more

Impacted file tree graph

@HarsheetKakar
Copy link
Contributor Author

@czgdp1807 please check this one too

@czgdp1807
Copy link
Member

czgdp1807 commented Mar 30, 2020

This highlights a potential flaw. Will look more into it before commenting further.

@HarsheetKakar
Copy link
Contributor Author

This highlights a potential flaw. Will look more into it before commenting further.

are you working on it yourself or shall I raise an issue listing all the problems with array.py?

@HarsheetKakar
Copy link
Contributor Author

That was lame, I'm so sorry that I didn't figure it out on my own. Thanks for helping me out.

@czgdp1807 czgdp1807 merged commit 797ec26 into codezonediitj:master Mar 31, 2020
Vanshika266 pushed a commit to Vanshika266/pydatastructs that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants