Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed _left_rotate and _right_rotate #238

Merged
merged 13 commits into from
Apr 6, 2020

Conversation

Aimaanhasan
Copy link
Contributor

References to other Issues or PRs or Relevant literature

Fixes #234

Brief description of what is fixed or changed

Removed assumption rotates were making for parent of j.

Other comments

See Issue #234

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #238 into master will increase coverage by 0.015%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #238       +/-   ##
=============================================
+ Coverage   98.562%   98.578%   +0.015%     
=============================================
  Files           24        24               
  Lines         2087      2110       +23     
=============================================
+ Hits          2057      2080       +23     
  Misses          30        30               
Impacted Files Coverage Δ
pydatastructs/trees/binary_trees.py 96.975% <100.000%> (+0.024%) ⬆️
pydatastructs/linear_data_structures/__init__.py 100.000% <0.000%> (ø)
pydatastructs/linear_data_structures/algorithms.py 100.000% <0.000%> (ø)
pydatastructs/trees/heaps.py 97.837% <0.000%> (+0.035%) ⬆️

Impacted file tree graph

@czgdp1807
Copy link
Member

Please add a regression test(your example in the issue) in test_binary_tree.py.

def test_issue_234():
    """
    link to issue
    """
    # your example    

@czgdp1807 czgdp1807 added bug Something isn't working trees rgsoc20 labels Mar 30, 2020
Aimaanhasan added a commit to Aimaanhasan/pydatastructs that referenced this pull request Mar 30, 2020
@czgdp1807
Copy link
Member

Any updates?

@Aimaanhasan
Copy link
Contributor Author

Added the test @czgdp1807.

@czgdp1807
Copy link
Member

Thank you for the efforts. Merging.

@czgdp1807 czgdp1807 merged commit 307b13e into codezonediitj:master Apr 6, 2020
Vanshika266 pushed a commit to Vanshika266/pydatastructs that referenced this pull request Apr 7, 2020
* Fixed SelfBalancingBinaryTree._left_rotate and SelfBalancingBinaryTree._right_rotate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trees
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_left_rotate and _right_rotate in SelfBalancingBinaryTree
2 participants