-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced the tests of Binary Trees that need manual string matching #304
Replaced the tests of Binary Trees that need manual string matching #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 98.866% 98.866%
=========================================
Files 25 25
Lines 2999 2999
=========================================
Hits 2965 2965
Misses 34 34 |
Seems good. Will merge tomorrow. |
There is this function which isn't tested. May be the tests for only this method can be kept along side the new tests. |
There since I have replaced all the tests of the binary trees ,and all its derivatives. The But here comes two issues that the So code coverage has been reduced. |
Shall I add explicit tests for the |
Yes. Sure |
ece87e8
to
7450fac
Compare
I have added the tests for the |
References to other Issues or PRs or Relevant literature
Closes #294
Brief description of what is fixed or changed
Replaced the testing techniques of Binary Trees where initially a manual string has to be fed; to the check of In-order and Pre-order traversals.
Other comments
Since a unique tree exists with a set of In-order and Pre-order traversals, this check is comparatively easy to use as there is no need of feeding a string of the nodes, instead of which two sets of keys of nodes are fed.