Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cocktail shaker sort #312

Merged
merged 36 commits into from
Jan 13, 2021
Merged

Added cocktail shaker sort #312

merged 36 commits into from
Jan 13, 2021

Conversation

Arvind-raj06
Copy link
Member

@Arvind-raj06 Arvind-raj06 commented Jan 10, 2021

References to other Issues or PRs or Relevant literature

Closes #198.

Brief description of what is fixed or changed

Implementation of the Cocktail Shaker sort in this pull request in reference to the site https://www.sanfoundry.com/python-program-implement-cocktail-shaker-sort/

Other comments

I hope the description is quite useful and if you find any issue with this ping me.....

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #312 (7a4581c) into master (42832f7) will increase coverage by 0.007%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #312       +/-   ##
=============================================
+ Coverage   98.866%   98.873%   +0.007%     
=============================================
  Files           25        25               
  Lines         2999      3019       +20     
=============================================
+ Hits          2965      2985       +20     
  Misses          34        34               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/__init__.py 100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py 99.502% <100.000%> (+0.054%) ⬆️

Impacted file tree graph

@czgdp1807
Copy link
Member

Please add tests. See linear_data_structures/tests/test_algorithms.py for pattern of testing followed for sorting algorithms.

@Arvind-raj06
Copy link
Member Author

Yeah process done

@Arvind-raj06
Copy link
Member Author

@czgdp1807 Is there any other improvements needed !?

@czgdp1807 czgdp1807 changed the title Updation cocktail Added cocktail shaker sort Jan 13, 2021
@czgdp1807 czgdp1807 merged commit 38e8712 into codezonediitj:master Jan 13, 2021
@czgdp1807
Copy link
Member

@Arvind-raj06 Are you contributing through SWOC-2021? Or any other open source program?

@Arvind-raj06
Copy link
Member Author

Arvind-raj06 commented Jan 13, 2021

@Arvind-raj06 Are you contributing through SWOC-2021? Or any other open source program?

Yes through SWOC

@Arvind-raj06
Copy link
Member Author

Before this I didn't knew that there is project on python! I just determined myself to work on this one. There are a few projects on py in SWOC this one really awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cocktail Sort
4 participants