upper_bound and lower_bound functions added

[sHiVaNgI821]

References to other Issues or PRs or Relevant literature

Added the upper_bound and lower_bound functions to the algorithms library. Upper_bound returns the index of the first occurence of an element greater than value, in the given sorted OneDimensionalArray. Lower_bound returns the index of the first occurence of an element which is not less than value, in the given OneDimensionalArray.

Brief description of what is fixed or changed

Other comments

[codecov]

Codecov Report

Merging #351 (c676829) into master (e1134b1) will increase coverage by 0.013%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #351       +/-   ##
=============================================
+ Coverage   98.561%   98.574%   +0.013%     
=============================================
  Files           25        25               
  Lines         3267      3297       +30     
=============================================
+ Hits          3220      3250       +30     
  Misses          47        47               

Impacted Files	Coverage Δ
pydatastructs/linear_data_structures/__init__.py	100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py	99.653% <100.000%> (+0.040%)	⬆️

[Smit-create]

@sHiVaNgI821 Please address this #344 (comment) in your PR too

[Smit-create]

The order needs to be well defined. i.e, strict inequality is followed in order. You can have a look at the implementation here: https://en.cppreference.com/w/cpp/algorithm/upper_bound.

[Smit-create]

Suggested change

	mid = (start+end)//2
	if comp(array[mid],value):
	mid = (start + end)//2
	if comp(array[mid], value):

[Smit-create]

The line width should not exceed 79 characters. Wrap up text in multiple lines not more than 79 chars

[Smit-create]

Suggested change

	output: int
	Lower bound of the given value in the given sorted OneDimensionalArray
	output: int
	Lower bound of the given value in the given sorted OneDimensionalArray

[Smit-create]

Suggested change

	mid = (start+end)//2
	if comp(array[mid],value):
	mid = (start + end)//2
	if comp(array[mid], value):

[Smit-create]

Suggested change

	end = mid -1
	end = mid - 1

[Smit-create]

This looks good. Just have a look at some suggestions.

[Smit-create]

Index of upper bound of given value...

[Smit-create]

Same

[Smit-create]

From, here I think there needs a slight change in the algo. That is output 2 isn't correct mathematically for this in the given range. Hence, we should consider the interval as [start, end). And so, I expect the output of it as 3. (You can verify it by yourself, we are making it similar to cpp)

[Smit-create]

Also, after making this interval change, please add tests apart from [0, len(arr)) interval too.

[Smit-create]

Looks good to me.

[Smit-create]

@czgdp1807 Have a look at it

[Smit-create]

@sHiVaNgI821 Please resolve merge conflicts

[Smit-create]

Apply these suggestions to both functions. Apart from this, it looks good to me.

[Smit-create]

Suggested change

	start: int
	The staring index of the portion of the array in which the upper bound
	of a given value has to be looked for
	end: int
	The ending index of the portion of the array in which the upper bound
	of a given value has to be looked for
	start: int, optional.
	The staring index of the portion of the array in which the upper bound
	of a given value has to be looked for. By default is 0.
	end: int, optional
	The ending index of the portion of the array in which the upper bound
	of a given value has to be looked for. By default is len(array)
	comp: boolean funtion, optional
	A function that takes two paramters and returns True if 1st parameter is strictly
	smaller than 2nd parameter

[Smit-create]

Remove this comment

[czgdp1807]

Looks Good. Will polish it and push back again.

[Smit-create]

@czgdp1807 This can be merged.

[czgdp1807]

Thanks.