Corrected API in longest_increasing_subsequence #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
=============================================
+ Coverage 98.618% 98.620% +0.002%
=============================================
Files 26 26
Lines 3401 3407 +6
=============================================
+ Hits 3354 3360 +6
Misses 47 47
|
czgdp1807
reviewed
Oct 11, 2021
| @@ -1010,16 +1010,18 @@ def longest_increasing_subsequence(array): | |||
| >>> from pydatastructs import longest_increasing_subsequence as LIS | |||
| >>> array = ODA(int, [2, 5, 3, 7, 11, 8, 10, 13, 6]) | |||
| >>> longest_inc_subsequence = LIS(array) | |||
| >>> longest_inc_subsequence | |||
| >>> print(longest_inc_subsequence) | |||
There was a problem hiding this comment.
Use str(longest_inc_subsequence).
czgdp1807
added
algorithms
enhancement
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected API in longest_increasing_subsequence. Previous was returning a list instead of an ODA
References to other Issues or PRs or Relevant literature
Fixes #407
Brief description of what is fixed or changed
The API is expected to return an OneDimensionalArray (ODA). However, the previous API was returning a list instead of an ODA. I've fixed this issue.
Other comments