Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated object to class name #57 #63

Merged
merged 8 commits into from
Dec 26, 2019
Merged

Updated object to class name #57 #63

merged 8 commits into from
Dec 26, 2019

Conversation

TarunTomar122
Copy link
Contributor

fixes #57

Brief description of what is fixed or changed

Replaced lines having object.new to base class name new..

Other comments

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@89c43ae). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage          ?   98.17%           
=========================================
  Files             ?       19           
  Lines             ?     1257           
  Branches          ?        0           
=========================================
  Hits              ?     1234           
  Misses            ?       23           
  Partials          ?        0
Impacted Files Coverage Δ
...datastructs/miscellaneous_data_structures/stack.py 92.307% <100%> (ø)
pydatastructs/trees/heaps.py 98.591% <100%> (ø)

Impacted file tree graph

@czgdp1807
Copy link
Member

Make the changes at the following place as well,

obj = object.__new__(cls)

@TarunTomar122
Copy link
Contributor Author

But Binary heap is not inheriting any other class than object class itself!

@czgdp1807
Copy link
Member

Well, then we need to make it inherit, Heap and then make the change. In future, there may be a need to shift some common methods to the topmost class.

@czgdp1807
Copy link
Member

Thanks. Merging.

@czgdp1807 czgdp1807 merged commit a8e2a96 into codezonediitj:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obj = object.__new__(cls)
2 participants