-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade and fix builds #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the readme and the commands. Fix javascript not getting compiled by the build action.
This means that we won't accidentally forget to exclude files.
This will make your SDDs/hard drives and your CPU happy while still doing exactly the same as before!
Get rid of NPM jobs that we dont need with eleventys passthroughs.
Oaphi
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ♥ Nothing else to add — this is a major improvement all around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run dev
command to start a dev server. It will automatically reload your page in the browser with the changes when you make any change to SCSS, TypeScript or Docs sources for really smooth and speedy development.npm run css_build/js_build/docs_build
will build the respective component only.npm run build
will now build all.package.json
to make sure we don't accidentally include unnecessary files (like we were doing for a while already)./dist
is generated from SCSS in/src
/js
is generated from TypeScript in/js_src
/docs
is generated from Markdown / HTML templates in/docs_src
After merging this, a small configuration setting on the repo may be necessary to set GitLab pages to work from GitHub actions.
Fixes #82
Fixes #86