Merge pull request #1183 from codidact/0valt/privilege-edit-fix

Fix not being able to edit privilege thresholds to 0 from the admin panel
codidact · Aug 22, 2023 · 566683e · 566683e
2 parents 66cb7a9 + 8400a35
commit 566683e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/app/assets/javascripts/privileges.js b/app/assets/javascripts/privileges.js
@@ -27,7 +27,11 @@ $(() => {
     const $input = $td.find('.js-privilege-edit');
     const name = $input.data('name');
     const type = $input.data('type');
-    const value = parseFloat($input.val() || '') || null;
+
+    // incorrect input values will cause rawValue to be NaN
+    const rawValue = parseFloat($input.val())
+
+    const value = Number.isNaN(rawValue) ? null : rawValue;
 
     const resp = await fetch(`/admin/privileges/${name}`, {
       method: 'POST',