Merge pull request #1384 from codidact/cellio/fix-500-on-delete

don't try to update rep for the nil user
codidact · Aug 25, 2024 · 71a6eca · 71a6eca
2 parents 1dfd966 + 3beb811
commit 71a6eca
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/models/post.rb b/app/models/post.rb
@@ -261,9 +261,9 @@ def modify_author_reputation
     if sc.include?('deleted') && sc['deleted'][0] != sc['deleted'][1] && created_at >= 60.days.ago
       deleted = !!saved_changes['deleted']&.last
       if deleted
-        user.update(reputation: user.reputation - Vote.total_rep_change(votes))
+        user&.update(reputation: (user&.reputation || 1) - Vote.total_rep_change(votes))
       else
-        user.update(reputation: user.reputation + Vote.total_rep_change(votes))
+        user&.update(reputation: (user&.reputation || 1) + Vote.total_rep_change(votes))
       end
     end
   end