Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't try to update rep for the nil user #1384

Merged
merged 3 commits into from
Aug 25, 2024
Merged

don't try to update rep for the nil user #1384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cee414
don't try to update rep for the nil user
cellio Aug 23, 2024
60903e1
PR review
cellio Aug 25, 2024
3beb811
Merge branch 'develop' into cellio/fix-500-on-delete
cellio Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/post.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ def modify_author_reputation
if sc.include?('deleted') && sc['deleted'][0] != sc['deleted'][1] && created_at >= 60.days.ago
deleted = !!saved_changes['deleted']&.last
if deleted
user.update(reputation: user.reputation - Vote.total_rep_change(votes))
user&.update(reputation: (user&.reputation || 1) - Vote.total_rep_change(votes))
else
user.update(reputation: user.reputation + Vote.total_rep_change(votes))
user&.update(reputation: (user&.reputation || 1) + Vote.total_rep_change(votes))
end
end
end
Expand Down
Loading