-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalized footer #1402
generalized footer #1402
Conversation
…, generated list of communities replaced with dashboard link; also added some guidance to the dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only change I'd make, though, is changing "This Network" to something else. If it confuses me, pretty sure it will be even more confusing to outside users. Non-blocking, though (and I honestly have no idea how to word it better).
I'm certainly open to changing it -- I'm just not sure to what. "Communities on this server" doesn't seem much clearer, and I don't think "instance" is widely understood. |
Short answer: Long answer: In the paragraph on the dashboard, I would probably say something like:
(Less to read and less to be confused about.) In the footer, I would expect the separation into two sections to have no meaning for many users, and to be a source of confusion. Unless I already know about Codidact, the heading "The Codidact Project" is unlikely to change my expectation that the link "contact us" will be to contact the owners of the website. For every instance except one, this will be incorrect. My suggestion would be to remove the two section headings, and only include links that relate to the instance (ideally in a way that is configurable without needing a code change). "About us" and "Contact us" should both relate to the instance. Perhaps in future work they could become relative URLs like the others. There can then be a single link to codidact.org with text that distinguishes it from all the other links, which are instance-specific. Perhaps something like "Powered by Codidact" (please someone suggest something better). This could possibly be separate from the bullet point list of links (I can imagine it in the version label below the footer:
If I want to read about or contact Codidact, I can follow that link and understand that any links on that new page relate to Codidact, which powers the website I just left. I think this will be clearer to users than trying to have both a "Contact Codidact" and "Contact Acme" (for the instance) in the same footer. Parts of this that sound reasonable might be best in other issues - I'm not suggesting we do everything in one pull request. |
… the network faq, added comments to the faq seed directing other instances to put in some contact/support info there (made that change on our network already)
@trichoplax I've made some adjustments, thanks, including moving support/contact info into the network FAQ where other instances can edit it. On-site config would be even better...someday. |
Minor nit for the network FAQ: specifying "software" twice in a row is unnecessary, and a more appropriate term would be "engine", imo:
Another (optional, the value's taken directly from git, so not directly related to your changes) thing is let's prettify the timestamp a bit. For me, it looks like this (negative offset that a UTC+0 timestamp would have from my locale) which is anything but readable (I'd keep the ISO8601 format but at least add a colon between hours and minutes and show it in UTC+0):
|
Latest version timestamp format fixup
…ithub.com/codidact/qpixel into cellio/1349-generalize-footer-communities
Sorted the footer links into "this network" and "Codidact project". Replaced the generated list of communities (which was getting long and was a little buggy) with a dashboard link. Added some wayfinding to the dashboard page, including pointer to the communities switcher.
This change removes the baked-in
codidact.com
link that is incorrect for other networks. I added the GitHub link under "Codidact project" to make the OSS platform a little more visible on other networks (maybe they want to contribute too).Closes #1349 and (indirectly) #1216.