Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV2-4344 add workspace tracing #693

Merged
merged 1 commit into from
Nov 27, 2023
Merged

DEV2-4344 add workspace tracing #693

merged 1 commit into from
Nov 27, 2023

Conversation

amircodota
Copy link
Contributor

No description provided.

@yonip23
Copy link
Contributor

yonip23 commented Nov 27, 2023

its easier to debug if its one event with different properties, then you can apply breakdowns easily.
create the properties map in the beginning of the function, then in each case add "reason": <the reason> entry to the map, and in the end add "success": true

@amircodota amircodota requested a review from a team as a code owner November 27, 2023 20:17
@amircodota
Copy link
Contributor Author

Not sure I agree. It is easier for me to follow a trace of events

yonip23
yonip23 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@yonip23 yonip23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amircodota amircodota merged commit 90e9f75 into master Nov 27, 2023
8 of 9 checks passed
@amircodota amircodota deleted the workspace-trace branch November 27, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonip23 yonip23 yonip23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amircodota @yonip23