Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV2-3247 - Fix: Startup Issue in devcontainers #1220

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

mikekosulin
Copy link
Contributor

Extension was failing to initialize correctly when launched in devcontainers. Upon investigating, it appears that users needed to manually input certain settings to workaround this issue.

To enable the Tabnine extension to work with devcontainers, users have been required to add the following settings to their VSCode settings.json:

// VSCode user's settings.json
{
  "remote.extensionKind": {
    "TabNine.tabnine-vscode": [
      "ui",
      "workspace"
    ]
  }
}

Considering the complexity and inconvenience this imposes on users, I've prepared this PR to address and resolve the issue.

@mikekosulin mikekosulin requested a review from a team as a code owner July 21, 2023 12:00
@dimacodota dimacodota self-assigned this Jul 22, 2023
@@ -93,6 +93,10 @@
"activationEvents": [
"*"
],
"extensionKind": [
"ui",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mikekosulin, is there any specific reason for choosing this order and not ["workspace", "ui"]?

Copy link
Contributor Author

@mikekosulin mikekosulin Jul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I’ve checked a few options and ["workspace", "ui"] doesn’t affect on the issue. So Tabnine extension activates if setting is ["ui", "workspace"] or ["ui"]

You can easily check it by following these steps to reproduce:

  1. Start any devcontainer
  2. Install Tabnine extension
  3. Add the the code below to your settings and reload the VS Code window:
// VSCode user's settings.json
{
  "remote.extensionKind": {
    "TabNine.tabnine-vscode": [
      "workspace",
      "ui"
    ]
  }
}

Also in my opinion, #534 would be beneficial to merge.

Copy link
Contributor

@dimacodota dimacodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimacodota dimacodota changed the title Fix: Startup Issue in devcontainers DEV2-3247 - Fix: Startup Issue in devcontainers Jul 23, 2023
@dimacodota dimacodota merged commit db49fab into codota:master Jul 23, 2023
1 of 2 checks passed
@mikekosulin mikekosulin deleted the fix/devcontainers-activation branch July 23, 2023 13:51
ofekby pushed a commit that referenced this pull request Aug 1, 2023
Former-commit-id: 3d2a3957fb46241fe417465be6f9c4e8b310ff6e [formerly 60b5746090fd81cfa4a7cbd9627bdd5ac98ce4e4] [formerly a682bd27b21f147a8c94ad8d412564f911d70d26 [formerly db49fab]]
Former-commit-id: bb13f7a24090018334209012a8ad33c274a0c2c5 [formerly 4c72eaddffa5919e9e1b1c1683d6e2a5b307e84e]
Former-commit-id: 3ba43c355611ca93533bce5015aa479615262713
@amircodota
Copy link
Contributor

@mikekosulin

Hi, Mike

I am afraid we have to revert this PR.

It causes issues to many users working via remote ssh and other remote options.

I think we need to come up with a different solution for devcontainers - one that allows tabnine to run inside the container.

We will be looking into this and would love your input. So feel free to open an issue or contact our support and describe your situation in more detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants