-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV2-3247 - Fix: Startup Issue in devcontainers #1220
DEV2-3247 - Fix: Startup Issue in devcontainers #1220
Conversation
@@ -93,6 +93,10 @@ | |||
"activationEvents": [ | |||
"*" | |||
], | |||
"extensionKind": [ | |||
"ui", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mikekosulin, is there any specific reason for choosing this order and not ["workspace", "ui"]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I’ve checked a few options and ["workspace", "ui"]
doesn’t affect on the issue. So Tabnine extension activates if setting is ["ui", "workspace"]
or ["ui"]
You can easily check it by following these steps to reproduce:
- Start any devcontainer
- Install Tabnine extension
- Add the the code below to your settings and reload the VS Code window:
// VSCode user's settings.json
{
"remote.extensionKind": {
"TabNine.tabnine-vscode": [
"workspace",
"ui"
]
}
}
Also in my opinion, #534 would be beneficial to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Former-commit-id: 3d2a3957fb46241fe417465be6f9c4e8b310ff6e [formerly 60b5746090fd81cfa4a7cbd9627bdd5ac98ce4e4] [formerly a682bd27b21f147a8c94ad8d412564f911d70d26 [formerly db49fab]] Former-commit-id: bb13f7a24090018334209012a8ad33c274a0c2c5 [formerly 4c72eaddffa5919e9e1b1c1683d6e2a5b307e84e] Former-commit-id: 3ba43c355611ca93533bce5015aa479615262713
Hi, Mike I am afraid we have to revert this PR. It causes issues to many users working via remote ssh and other remote options. I think we need to come up with a different solution for devcontainers - one that allows tabnine to run inside the container. We will be looking into this and would love your input. So feel free to open an issue or contact our support and describe your situation in more detail |
Extension was failing to initialize correctly when launched in devcontainers. Upon investigating, it appears that users needed to manually input certain settings to workaround this issue.
To enable the Tabnine extension to work with devcontainers, users have been required to add the following settings to their VSCode settings.json:
Considering the complexity and inconvenience this imposes on users, I've prepared this PR to address and resolve the issue.