feat: switch from Date to Temporal #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is very cool! I didn't even know it was an issue. I need to do some reading on this Temporal stuff. 🤔 |
|
It's the future of time itself in JS. Currently it's blocked by the IETF needing to standardize an extension to RFC3339/ISO8601 tc39/proposal-temporal#1450 |
NiallJoeMaher
approved these changes
Aug 1, 2022
NiallJoeMaher
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tc39.es/proposal-temporal/docs/
ran into some cases where the server hydration would break because of a difference in locale between server and client. Proper fix is to restrict it to client side only, but for now I'll hardcode it to
en-IE, and ditch the useless Date for the glorious if still in Stage 3 Temporal.