Update dependencies and fix compilation errors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompilation errors
…phics::DrawState)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Cool 2048 clone! I was not able to compile it with Rust 1.11 due to an old version of crossbeam in the piston dependencies (see crossbeam-rs/crossbeam#75). I updated the piston dependencies in the Cargo.toml file to the latest stable versions.
I changed lines with default_draw_state() to &DrawState::default(). Actually, I am not sure about that change, because I have not worked that much with Piston. That just seemed the most obvious fix.
Another change was the type of the actual window and the specification of the OpenGL version. The documentation at http://docs.piston.rs/piston_window/window/struct.WindowSettings.html suggests, that OpenGL 3.2 is the default version.
Furthermore, the event loop format is different now and I changed it based on the example at http://www.piston.rs/.
Denis