Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentinel 2 cog prefix #22

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Fix sentinel 2 cog prefix #22

merged 2 commits into from
Oct 1, 2020

Conversation

kylebarron
Copy link
Member

with S2COGReader('S2B_12SYJ_20200901_0_L2A') as scene:
    pass

currently errors with a NoSuchKey exception. This is because the directory structure of the bucket changed

This key exists:

s3://sentinel-cogs/sentinel-s2-l2a-cogs/12/S/YJ/2020/9/S2B_12SYJ_20200901_0_L2A/

@vincentsarago
Copy link
Member

@kylebarron can you update the tests please!

@vincentsarago
Copy link
Member

👋 @matthewhanson will there be any other change in the bucket?

side question: are the stac items up to date?

@matthewhanson
Copy link

@vincentsarago @kylebarron The only change going forward will be the removal of the older prefix that starts with acquisitionYear.

The STAC records should be up to date, although in the next few weeks there will be some small fixes and updates to the metadata, I don't have a complete list of those yet.

@vincentsarago
Copy link
Member

thanks @matthewhanson that's great.

from rio-tiler-pds POV metadata change won't impact us because we only use the assets and bbox info https://github.com/cogeotiff/rio-tiler-pds/blob/master/rio_tiler_pds/sentinel/aws/sentinel2.py#L232-L235

@vincentsarago vincentsarago merged commit c32e6d0 into master Oct 1, 2020
@vincentsarago vincentsarago deleted the kyle/s2-cog-prefix branch October 1, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants