Fix sentinel 2 sceneid parser for single-digit UTM zones #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
changed the title
|
Should I change the "old style" regex here too? |
|
@kylebarron looking at the ESA specification it seems to me the tile id should always be in form of I'm ok changing this but we have to 🤞 for the format of the scene id to stay as it is cc @matthewhanson |
vincentsarago
requested changes
Dec 1, 2020
rio_tiler_pds/sentinel/utils.py
Outdated
| @@ -48,14 +48,14 @@ def s2_sceneid_parser(sceneid: str) -> Dict: | |||
| ) | |||
|
|
|||
| elif re.match( | |||
| "^S2[AB]_[0-9]{2}[A-Z]{3}_[0-9]{8}_[0-9]_L[0-2][A-C]$", sceneid | |||
| "^S2[AB]_[0-9]{1,2}[A-Z]{3}_[0-9]{8}_[0-9]_L[0-2][A-C]$", sceneid | |||
There was a problem hiding this comment.
I guess it's ok to change the old style scene id too. Can you do it @kylebarron. would also be nice to add entry in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
sceneids in thesentinel-cogsbucket, scene ids for single-digit UTM zones don't have a leading0, e.g.S2B_2CMA_20181002_0_L2A, which fails with the current regex.