refactor SpatialMixin.tile_exists to avoid coordinates overflow #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Nov 10, 2021
| COG_EARTH, tms=morecantile.tms.get("EuropeanETRS89_LAEAQuad") | ||
| ) as cog: | ||
| img = cog.tile(0, 0, 1, tilesize=64) | ||
| assert img.data.shape == (1, 64, 64) |
There was a problem hiding this comment.
This would have failed with the previous code
vincentsarago
commented
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another of the
tile_existsmethod.When converting bounds from the dataset's CRS to the TMS's CRS it could result in coordinates overflow (a dataset can have bounds bigger than the TMS's CRS bounds). It's safer to apply the opposite: converting the tile_bounds from the TMS's CRS to the dataset's CRS.