geospatial aggregation to support output #1032

tuanng-cognite · 2022-09-15T08:13:36Z

No description provided.

# Conflicts: # CHANGELOG.md # cognite/client/_version.py # pyproject.toml

codecov · 2022-09-26T14:40:19Z

Codecov Report

Merging #1032 (3b1c5fe) into master (98f5033) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 3b1c5fe differs from pull request most recent head 4d14c76. Consider uploading reports for the commit 4d14c76 to get more accurate results

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   90.42%   89.95%   -0.47%     
==========================================
  Files          76       76              
  Lines        7662     7738      +76     
==========================================
+ Hits         6928     6961      +33     
- Misses        734      777      +43

Impacted Files	Coverage Δ
cognite/client/_api/geospatial.py	`89.78% <100.00%> (+0.15%)`	⬆️
cognite/client/_version.py	`100.00% <100.00%> (ø)`
cognite/client/data_classes/raw.py	`93.47% <0.00%> (-4.20%)`	⬇️
...e/client/data_classes/transformations/schedules.py	`93.54% <0.00%> (-3.01%)`	⬇️
...nite/client/data_classes/transformations/schema.py	`97.56% <0.00%> (-2.44%)`	⬇️
cognite/client/data_classes/labels.py	`94.91% <0.00%> (-1.58%)`	⬇️
cognite/client/data_classes/assets.py	`90.19% <0.00%> (-1.31%)`	⬇️
cognite/client/_api/raw.py	`93.95% <0.00%> (-1.25%)`	⬇️
cognite/client/data_classes/geospatial.py	`95.45% <0.00%> (-1.24%)`	⬇️
cognite/client/_api/synthetic_time_series.py	`93.58% <0.00%> (-1.15%)`	⬇️
... and 25 more

vincent-cognite

Looks good!
Can you show an example for 2 different properties since this was the core reason for the change in the api?
Also, can we annotate the parameters with some "deprecation" warning or something? (I'm not familiar with how this could be done)

tuanng-cognite · 2022-09-27T11:50:10Z

@vincent-cognite https://github.com/cognitedata/cognite-sdk-python/pull/1032/files#diff-6e996bb467c7a2411a485aa9e3b1140f21379862ace9c80f0979d22fc44db42dR820 deprecation warning is shown when old properties are used.

commit b317169 Author: Håkon V. Treider <[email protected]> Date: Tue Oct 4 01:46:43 2022 +0200 Dps Fetch Refactor #5: New dps fetch code (#1043) * New dps fetch code * typos and tweaks * Update cognite/client/_api/datapoint_tasks.py * forgot self arg... * Fix insertion of DatapointsArray * Make dps retrieve method kwargs only * fstring fix * Fix to avoid float dtype for count agg commit 4e673cb Author: Håkon V. Treider <[email protected]> Date: Tue Oct 4 01:43:13 2022 +0200 Dps Fetch Refactor #9: Unit tests, added, fixed and improved. (#1047) * Unit tests, added, fixed and improved. * add test for split_into_n_parts and find_duplicates commit 8099cb3 Author: Håkon V. Treider <[email protected]> Date: Tue Oct 4 01:42:49 2022 +0200 Integration tests, added, fixed and improved (#1048) commit a049ec4 Author: Håkon V. Treider <[email protected]> Date: Tue Oct 4 01:42:30 2022 +0200 Dps Fetch Refactor #11: Readme, docs and changelog (#1049) * Readme, docs and changelog * Improve changelog * Changelog almost done * Mooooooare changelog details * Apply 12 spell check suggestions from code review * Reword the note about `include_aggregate_name` * Update CHANGELOG.md commit e74699e Author: Håkon V. Treider <[email protected]> Date: Tue Oct 4 00:21:33 2022 +0200 Dps Fetch Refactor #12: Fix `ms_to_datetime` on windows (#1056) * Fix ms_to_datetime for windows * make single ms_to_datetime impl. work on all OSs. remove removed warnings from filterwarnings commit 59aace9 Author: Håkon V. Treider <[email protected]> Date: Tue Oct 4 00:11:57 2022 +0200 Dps Fetch Refactor #6: Add array-based data classes. Change camel case defaults (#1044) * Add array-based data classes. Change camel case defaults * No copy in df constructor from numpy arrays yields another 100 x * Update cognite/client/data_classes/datapoints.py * Update cognite/client/data_classes/datapoints.py * remove unnecessary list conv * Remove _strip_aggregate_names entirely commit f0b0525 Author: Håkon V. Treider <[email protected]> Date: Fri Sep 30 14:04:31 2022 +0200 Dps Fetch Refactor #7: Extend utils with new functionality (#1045) * Extend utils with new functionality * add hashable bound to type var commit c281ac0 Author: Håkon V. Treider <[email protected]> Date: Fri Sep 30 14:04:00 2022 +0200 Dps Fetch Refactor #3: Add ThreadPoolExecutor with PriorityQueue (#1041) * Add ThreadPoolExecutor with PriorityQueue * move mypy ignore flag to ini file commit 920cd84 Author: Håkon V. Treider <[email protected]> Date: Fri Sep 30 13:12:17 2022 +0200 Dps Fetch Refactor #2: Update dependencies and version. Run poetry lock (#1040) * Update dependencies and version. Run poetry lock * relax and tighten dep. reqs * Trim pandas version (no-op) commit f0a69d8 Merge: 6be4b44 7abd1c2 Author: Håkon V. Treider <[email protected]> Date: Thu Sep 29 02:22:23 2022 +0200 Merge branch 'master' into v5-release commit 7abd1c2 Author: Jaime Silva <[email protected]> Date: Wed Sep 28 03:55:39 2022 -0500 Rename alpha data models destination in transformations (#1050) * rename alpha data models to data models * version bump * unskip dms and jobs tests * show warning when using FDMs on transformations commit aa3f52b Author: tuanng-cognite <[email protected]> Date: Tue Sep 27 14:00:50 2022 +0200 geospatial aggregation to support output (#1032) * geospatial aggregation to support output * format * rename * fix deprecation message * improve example commit 6be4b44 Merge: 88c3877 98f5033 Author: Håkon V. Treider <[email protected]> Date: Tue Sep 27 03:06:22 2022 +0200 Merge branch 'master' into v5-release commit 88c3877 Author: Håkon V. Treider <[email protected]> Date: Tue Sep 27 03:04:20 2022 +0200 Cleanup of CogClient mock duplicates. Update with 20 missing APIs... (#1046) commit 9b30dba Author: Håkon V. Treider <[email protected]> Date: Tue Sep 27 02:48:55 2022 +0200 Move DatapointsAPI to time_series.data. Many minor fixups. Bump max_workers to 20. (#1042) commit 98f5033 Author: Håkon V. Treider <[email protected]> Date: Mon Sep 26 19:44:30 2022 +0200 Simplify github workflows. Minor project linting settings changes (#1039) * Simplify GitHub workflows. Minor project linting settings changes

tuanng-cognite added 3 commits September 15, 2022 10:13

geospatial aggregation to support output

08637a9

format

9cd0ce3

Merge branch 'master' into geospatial-aggregate-output

88b6a92

# Conflicts: # CHANGELOG.md # cognite/client/_version.py # pyproject.toml

tuanng-cognite marked this pull request as ready for review September 26, 2022 14:19

tuanng-cognite requested review from a team as code owners September 26, 2022 14:19

rename

ce100cb

fix deprecation message

3b1c5fe

vincent-cognite approved these changes Sep 26, 2022

View reviewed changes

tuanng-cognite added 2 commits September 27, 2022 13:48

improve example

f9af48e

Merge branch 'master' into geospatial-aggregate-output

4d14c76

tuanng-cognite merged commit aa3f52b into master Sep 27, 2022

tuanng-cognite deleted the geospatial-aggregate-output branch September 27, 2022 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

geospatial aggregation to support output #1032

geospatial aggregation to support output #1032

tuanng-cognite commented Sep 15, 2022

codecov bot commented Sep 26, 2022 •

edited

Loading

vincent-cognite left a comment

tuanng-cognite commented Sep 27, 2022

geospatial aggregation to support output #1032

geospatial aggregation to support output #1032

Conversation

tuanng-cognite commented Sep 15, 2022

codecov bot commented Sep 26, 2022 • edited Loading

Codecov Report

vincent-cognite left a comment

Choose a reason for hiding this comment

tuanng-cognite commented Sep 27, 2022

codecov bot commented Sep 26, 2022 •

edited

Loading