Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer, using correct Python version image #1803

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

msusag
Copy link
Contributor

@msusag msusag commented Jun 10, 2024

Description

This sets the Python image for devcontainer to a 3.8 version, to be aligned with current setup in cognite-sdk-python.

Reverts #1758

Also disables automated RenoveBot updated for the devcontainer image, to avoid dependency uppdates from RenovateBot to again use a "too new" version.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@msusag msusag requested review from a team as code owners June 10, 2024 19:35
@msusag msusag requested review from mattmurph9 and removed request for a team June 10, 2024 19:35
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (774e0d9) to head (f307687).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1803   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         121      121           
  Lines       17700    17700           
=======================================
+ Hits        16444    16445    +1     
+ Misses       1256     1255    -1     

see 3 files with indirect coverage changes

@msusag msusag changed the title Fix-devcontainer Fix devcontainer, using correct Python version image Jun 10, 2024
@msusag msusag merged commit 319d743 into master Jun 11, 2024
14 checks passed
@msusag msusag deleted the fix-devcontainer branch June 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants