Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make views example less confusing #1982

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

erlendvollset
Copy link
Collaborator

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (f37aa94) to head (8f39ff3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1982   +/-   ##
=======================================
  Coverage   90.19%   90.20%           
=======================================
  Files         139      139           
  Lines       21756    21756           
=======================================
+ Hits        19622    19624    +2     
+ Misses       2134     2132    -2     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/views.py 95.83% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlendvollset erlendvollset added auto-update Will automatically keep PR up to date auto-merge labels Oct 18, 2024
@cognite-bulldozer cognite-bulldozer bot merged commit 8ca9b23 into master Oct 18, 2024
16 checks passed
@cognite-bulldozer cognite-bulldozer bot deleted the improve-view-example branch October 18, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge auto-update Will automatically keep PR up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants