Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove yaml tags for tuple in dump_yaml methods #1992

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Oct 23, 2024

While dumping a rather complex Query, I noticed we don't strip yaml tags specific to Python data types. I believe we should dump yaml without these.

@haakonvt haakonvt requested review from a team as code owners October 23, 2024 11:03
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (b971d77) to head (afc5fe2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/data_classes/_base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
+ Coverage   90.22%   90.23%   +0.01%     
==========================================
  Files         139      139              
  Lines       21825    21826       +1     
==========================================
+ Hits        19691    19695       +4     
+ Misses       2134     2131       -3     
Files with missing lines Coverage Δ
cognite/client/utils/_auxiliary.py 92.85% <100.00%> (+0.04%) ⬆️
cognite/client/data_classes/_base.py 92.84% <50.00%> (ø)

... and 2 files with indirect coverage changes

@haakonvt haakonvt merged commit ee2320e into master Oct 29, 2024
16 checks passed
@haakonvt haakonvt deleted the fix-yaml-tags branch October 29, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants