Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): Add support for simulation integration #1993

Closed
wants to merge 6 commits into from

Conversation

lpereiracgn
Copy link

@lpereiracgn lpereiracgn commented Oct 24, 2024

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (b5213d4) to head (bbbb7c3).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/data_classes/workflows.py 64.51% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
- Coverage   90.19%   90.16%   -0.04%     
==========================================
  Files         139      139              
  Lines       21772    21802      +30     
==========================================
+ Hits        19638    19657      +19     
- Misses       2134     2145      +11     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/__init__.py 100.00% <ø> (ø)
cognite/client/data_classes/workflows.py 93.21% <64.51%> (-1.75%) ⬇️

@lpereiracgn lpereiracgn marked this pull request as ready for review October 30, 2024 23:25
@lpereiracgn lpereiracgn requested review from a team as code owners October 30, 2024 23:25
@lpereiracgn lpereiracgn marked this pull request as draft October 30, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants