Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small simplification in _TypedNodeOrEdgeListAdapter #1994

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

erlendvollset
Copy link
Collaborator

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@erlendvollset erlendvollset requested review from a team as code owners October 25, 2024 12:07
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (9cb61f8) to head (120469c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/_api/data_modeling/instances.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1994   +/-   ##
=======================================
  Coverage   90.19%   90.20%           
=======================================
  Files         139      139           
  Lines       21772    21772           
=======================================
+ Hits        19638    19640    +2     
+ Misses       2134     2132    -2     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/instances.py 87.83% <66.66%> (ø)

... and 1 file with indirect coverage changes

@erlendvollset erlendvollset added auto-update Will automatically keep PR up to date auto-merge labels Oct 27, 2024
@cognite-bulldozer cognite-bulldozer bot merged commit 8369bcb into master Oct 27, 2024
16 checks passed
@cognite-bulldozer cognite-bulldozer bot deleted the simplify branch October 27, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge auto-update Will automatically keep PR up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants