-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning with API #1998
Aligning with API #1998
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1998 +/- ##
==========================================
+ Coverage 90.24% 90.27% +0.02%
==========================================
Files 139 139
Lines 21830 21885 +55
==========================================
+ Hits 19700 19756 +56
+ Misses 2130 2129 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can change the authentication
in MQTT to BasicAuthenticationWrite
and BasicAuthentication
.
In addition, this is a bit tricky to keep track of, so lets make a few manual test of the loading logic here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Description
Please describe the change you have made.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.