Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning with API #1998

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Aligning with API #1998

merged 6 commits into from
Nov 1, 2024

Conversation

ronpal
Copy link
Contributor

@ronpal ronpal commented Oct 30, 2024

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@ronpal ronpal requested review from a team as code owners October 30, 2024 15:02
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 95.58011% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (cb75c7e) to head (9632256).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...e/client/data_classes/hosted_extractors/sources.py 95.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
+ Coverage   90.24%   90.27%   +0.02%     
==========================================
  Files         139      139              
  Lines       21830    21885      +55     
==========================================
+ Hits        19700    19756      +56     
+ Misses       2130     2129       -1     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
...e/client/data_classes/hosted_extractors/sources.py 90.24% <95.55%> (+1.54%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can change the authentication in MQTT to BasicAuthenticationWrite and BasicAuthentication.

In addition, this is a bit tricky to keep track of, so lets make a few manual test of the loading logic here.

cognite/client/data_classes/hosted_extractors/sources.py Outdated Show resolved Hide resolved
cognite/client/data_classes/hosted_extractors/sources.py Outdated Show resolved Hide resolved
cognite/client/data_classes/hosted_extractors/sources.py Outdated Show resolved Hide resolved
@doctrino doctrino self-requested a review November 1, 2024 10:44
Copy link
Contributor

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ronpal ronpal merged commit 7f3591c into master Nov 1, 2024
16 checks passed
@ronpal ronpal deleted the hosted-extractor-fix branch November 1, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants