-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using Django development server in production #48
Stop using Django development server in production #48
Conversation
I love the goal of this PR! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abeedvisram It looks like you included some changes from the other PR in cognoma_site/settings.py. Can you remove those changes in order to keep within the scope of this PR?
Currently, we're using a sharing a single core for this web process. Do we want to change gunicorn.conf workers = 3
to workers = 2
? That may be a nitpick.
Other than that, looking good!
Updated and tested locally using the "prod" settings of Supervisord + Gunicorn. Works for me when testing on Dev using Django development server
Prod using Supervisord + Gunicorn
Process running as "nobody" under Supervisord
|
woo! great 👍 |
Motivation
Move away from using the Django development server in production as it's not suitable, see issue #39
API changes
None
Implementation Notes
Functional Tests
Not been able to verify that this runs locally, see issue #47
Screenshots/Logs
Will be updated once #47 has been resolved.