-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add templating for Jupyter notebooks. #13
base: master
Are you sure you want to change the base?
Conversation
FYI - I got this to work on my computer on my own dummy example. When I first ran it I got the following error:
When I commented out the I may use this for some other applications soon and I'll let you know how that works out. @wisygig and @dcgoss let me know if you want any review of the code in this PR. Nice work Jason! |
@rdvelazquez Interesting! Can you run a |
when I run
Here's a snippet of the output for reference (I couldn't really make sense of it):
The output ends with:
I have version 4.2.0 of nbformat installed (both when I list via conda and via pip). |
Ah, that explains it! I was working with nbformat 4.3.0. It should be in the |
That was it. I updated to nbformat 4.3.0, uncommented the |
Hey! I’ve been on vacation since last Friday, so I’ll take a look at this when I return on Monday. |
Wow, this is an amazing package! @wisygig you should really consider making this into a standalone package, something seems wrong about keeping it embedded into ml-workers. |
I'll second the standalone package comment! |
@dcgoss Yes, but only as a string. For example, |
@wisygig thanks for this cool PR. It's definitely a useful utility. I agree with @dcgoss and @rdvelazquez that it makes sense as a package. We have two options:
@dcgoss mentioned that we need some additional changes |
Motivation
Add templates for jupyter notebooks. Examples are available in the
README.md
file.API changes
None.
Implementation Notes
Anything that could be helpful to the reviewer. Especially if it not obvious from looking at the diffs.
Functional Tests
see
nb_util/tests/test_jupyter_template.py
.