Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toolkit): show assistant welcome message #255

Merged
merged 4 commits into from
Jun 21, 2024
Merged

feat(toolkit): show assistant welcome message #255

merged 4 commits into from
Jun 21, 2024

Conversation

knajjars
Copy link
Collaborator

@knajjars knajjars commented Jun 21, 2024 •
edited by cohere-pr-pal bot
Loading

  • Updates the <Welcome /> message to show assistant details or base assistant.
  • Improves animation for <ConversationListPanel />
Screen.Recording.2024-06-21.at.11.53.43.AM.mov

AI Description

This pull request introduces changes to the AgentsSidePanel, MessagingContainer, Conversation, Welcome, and AgentsPage components.

  • The AgentsSidePanel component now includes a setSettings prop and a setIsConvListPanelOpen prop. It also features a new handleToggleAgentsSidePanel function that updates the isConfigDrawerOpen and isAgentsSidePanelOpen settings.
  • The MessagingContainer component has a new optional agentId prop, which is also included in the Messages function.
  • The Conversation component now includes an agentId prop, which is passed to the Welcome component.
  • The Welcome component has been updated to use the useAgent hook, which accepts the agentId prop. It now conditionally renders the agent's name and description based on the agentId.
  • The AgentsPage component has updated the Transition component's animation properties.

@knajjars knajjars merged commit 338a9fa into main Jun 21, 2024
2 checks passed
@knajjars knajjars deleted the OS-2173 branch June 21, 2024 12:29
malexw pushed a commit that referenced this pull request Jun 21, 2024
@knajjars @malexw
feat(toolkit): show assistant welcome message (#255)
abe316e 
* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message
malexw added a commit that referenced this pull request Jun 21, 2024
@malexw @misspia-cohere
@tianjing-li @BeatrixCohere @lusmoura @scott-cohere @knajjars
frontend: Login, logout, and account creation (#179)
e67e226 
* add login page components

* Add Register page and hooks for auth

* Add the register page and connect all the frontend elements

* Redirect to /login if the token expires and clean up some console errors

* Add error messages for failed logins

* frontend: Add Single Sign-on to Toolkit (#227)

* Add Google SSO login plus OpenID components

* Dynamically set SSO login buttons and show or hide username and password based on auth_strategies

---------

Co-authored-by: Tianjing Li <[email protected]>

* fix startup event

* Fix build errors and update the API client

* Fix tests by adding missing env vars

Add test OIDC_WELL_KNOWN_ENDPOINT var to fixtures

* Add a walkthrough guide of the toolkit  (#251)

* GUide

* Chang

* Change

* Change

* Update docs/walkthrough/walkthrough.md

Co-authored-by: Luísa Moura <[email protected]>

* Update walkthrough.md

---------

Co-authored-by: Luísa Moura <[email protected]>

* coral-web: fix agent info panel opening by default (#253)

cast isEditAgentPanelOpen to boolean

* [backend] enforce agent update with user-id (#246)

* updates

* remove client changes

* remove logs

* use better header user id check

* fix validators

* typo

* Metrics: add middleware (#185)

* Metrics: add middleware

* add chat calls

* merge

* lint

* make it async

* add user id

* add more fields

* add retry and duration

* add meta

* comments

* fix tests

* improve error handling

* rename fields

* match spec

* comments

* clean code

* only create loop when theres endpoint

* add assistant id to chat

* feat(toolkit): show assistant welcome message (#255)

* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message

---------

Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Tianjing Li <[email protected]>
Co-authored-by: Beatrix De Wilde <[email protected]>
Co-authored-by: Luísa Moura <[email protected]>
Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Scott <[email protected]>
Co-authored-by: Khalil Najjar <[email protected]>
sanal-cohere pushed a commit that referenced this pull request Jun 21, 2024
@knajjars @sanal-cohere
feat(toolkit): show assistant welcome message (#255)
913b250 
* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message
sanal-cohere pushed a commit that referenced this pull request Jun 21, 2024
@malexw @misspia-cohere
@tianjing-li @BeatrixCohere @lusmoura @scott-cohere @knajjars @sanal-cohere
frontend: Login, logout, and account creation (#179)
c6cfeb6 
* add login page components

* Add Register page and hooks for auth

* Add the register page and connect all the frontend elements

* Redirect to /login if the token expires and clean up some console errors

* Add error messages for failed logins

* frontend: Add Single Sign-on to Toolkit (#227)

* Add Google SSO login plus OpenID components

* Dynamically set SSO login buttons and show or hide username and password based on auth_strategies

---------

Co-authored-by: Tianjing Li <[email protected]>

* fix startup event

* Fix build errors and update the API client

* Fix tests by adding missing env vars

Add test OIDC_WELL_KNOWN_ENDPOINT var to fixtures

* Add a walkthrough guide of the toolkit  (#251)

* GUide

* Chang

* Change

* Change

* Update docs/walkthrough/walkthrough.md

Co-authored-by: Luísa Moura <[email protected]>

* Update walkthrough.md

---------

Co-authored-by: Luísa Moura <[email protected]>

* coral-web: fix agent info panel opening by default (#253)

cast isEditAgentPanelOpen to boolean

* [backend] enforce agent update with user-id (#246)

* updates

* remove client changes

* remove logs

* use better header user id check

* fix validators

* typo

* Metrics: add middleware (#185)

* Metrics: add middleware

* add chat calls

* merge

* lint

* make it async

* add user id

* add more fields

* add retry and duration

* add meta

* comments

* fix tests

* improve error handling

* rename fields

* match spec

* comments

* clean code

* only create loop when theres endpoint

* add assistant id to chat

* feat(toolkit): show assistant welcome message (#255)

* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message

---------

Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Tianjing Li <[email protected]>
Co-authored-by: Beatrix De Wilde <[email protected]>
Co-authored-by: Luísa Moura <[email protected]>
Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Scott <[email protected]>
Co-authored-by: Khalil Najjar <[email protected]>
sanal-cohere added a commit that referenced this pull request Jun 21, 2024
@sanal-cohere @wujessica
@knajjars @lusmoura @tomtobac @tianjing-li @misspia-cohere @EugeneLightsOn @scott-cohere @BeatrixCohere @malexw
Adding Compass Tool (#240)
0c5db02 
* Initial commit for Compass Tool

* coral-web: update first turn suggestions (#225)

* Addressed comments on the previous commit

* Added custom_context to parse and filters to search

* Formatting changes

* feat(assistant): Update conversation header (#229)

* feat(assistant): Update conversation header

* feat(assistant): Update conversation header

* update tooltip

* fix IconButton import

* Setup: fix dependencies (#243)

* feat(toolkit): show conversation list on with agents list (#231)

* Setup: remove redundant dependency (#244)

* Improve Auth guide (#235)

improve auth guide

* coral-web: create agent + agent base form (#212)

* create new agent form

* render agents list

* link back to base agent page

* perform post submission actions

* move input labels outside of input borders

* move submit button

* gen client

* factor out agent base form

* use default content type

* list custom agents

* check if agent name is unique

* and deployment + env variables to agent form

* add deployments

* clean up

* add submit modal

* push to new agent page on create success

* only show available deployments

* remove deployments dropdown

* feat: List Assistants returned from API (#242)

* feat: list agents from BE

* Update src/interfaces/coral_web/src/components/Conversation/MessagingContainer.tsx

Co-authored-by: misspia-cohere <[email protected]>

---------

Co-authored-by: misspia-cohere <[email protected]>

* nits

---------

Co-authored-by: Khalil Najjar <[email protected]>

* Propagate should_store logic to the File upload logic (#247)

should_store logic to the attach_files_to_messages

* [backend] passing in agent when calling streaming chat (#237)

* initial chat changes

* need to test

* done

* Remove old test

* default model for agents right now

* Organizations DB models, CRUD and tests   (#238)

* Organizations initial commit

* Organizations initial commit

* Organizations initial commit - sync main

* Organizations initial commit - sync main - blacked

* Organizations initial commit - sync main - lint

* Organizations initial commit - sync main - tests

* Organizations initial commit - sync main - tests

* Organizations initial commit - review fixes

* Organizations initial commit - review fixes

* Split up display name and name for Tools  (#241)

* CHange

* change

* coral-web: update assistant (#248)

* create new agent form

* render agents list

* link back to base agent page

* perform post submission actions

* move input labels outside of input borders

* move submit button

* gen client

* factor out agent base form

* check if agent name is unique

* and deployment + env variables to agent form

* add deployments

* clean up

* remove deployments dropdown

* init agent page

* create agent drawer

* use agent form

* add update agent request

* add get agent request

* fix rebase errors

* remove model from agent form

* add agent drawer to conversation

* remove unused componenets

* use new agent name for update success message

* fix(toolkit): Address code feedback + improvements (#249)

address code feedback improvements

---------

Co-authored-by: Khalil Najjar <[email protected]>

* feat(toolkit): add/remove recently used agents (#250)

* feat(toolkit): add/remove recently used agents

* merge main

* Add a walkthrough guide of the toolkit  (#251)

* GUide

* Chang

* Change

* Change

* Update docs/walkthrough/walkthrough.md

Co-authored-by: Luísa Moura <[email protected]>

* Update walkthrough.md

---------

Co-authored-by: Luísa Moura <[email protected]>

* coral-web: fix agent info panel opening by default (#253)

cast isEditAgentPanelOpen to boolean

* [backend] enforce agent update with user-id (#246)

* updates

* remove client changes

* remove logs

* use better header user id check

* fix validators

* typo

* Metrics: add middleware (#185)

* Metrics: add middleware

* add chat calls

* merge

* lint

* make it async

* add user id

* add more fields

* add retry and duration

* add meta

* comments

* fix tests

* improve error handling

* rename fields

* match spec

* comments

* clean code

* only create loop when theres endpoint

* add assistant id to chat

* feat(toolkit): show assistant welcome message (#255)

* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message

* frontend: Login, logout, and account creation (#179)

* add login page components

* Add Register page and hooks for auth

* Add the register page and connect all the frontend elements

* Redirect to /login if the token expires and clean up some console errors

* Add error messages for failed logins

* frontend: Add Single Sign-on to Toolkit (#227)

* Add Google SSO login plus OpenID components

* Dynamically set SSO login buttons and show or hide username and password based on auth_strategies

---------

Co-authored-by: Tianjing Li <[email protected]>

* fix startup event

* Fix build errors and update the API client

* Fix tests by adding missing env vars

Add test OIDC_WELL_KNOWN_ENDPOINT var to fixtures

* Add a walkthrough guide of the toolkit  (#251)

* GUide

* Chang

* Change

* Change

* Update docs/walkthrough/walkthrough.md

Co-authored-by: Luísa Moura <[email protected]>

* Update walkthrough.md

---------

Co-authored-by: Luísa Moura <[email protected]>

* coral-web: fix agent info panel opening by default (#253)

cast isEditAgentPanelOpen to boolean

* [backend] enforce agent update with user-id (#246)

* updates

* remove client changes

* remove logs

* use better header user id check

* fix validators

* typo

* Metrics: add middleware (#185)

* Metrics: add middleware

* add chat calls

* merge

* lint

* make it async

* add user id

* add more fields

* add retry and duration

* add meta

* comments

* fix tests

* improve error handling

* rename fields

* match spec

* comments

* clean code

* only create loop when theres endpoint

* add assistant id to chat

* feat(toolkit): show assistant welcome message (#255)

* feat(toolkit): show assistant welcome message

* feat(toolkit): show assistant welcome message

---------

Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Tianjing Li <[email protected]>
Co-authored-by: Beatrix De Wilde <[email protected]>
Co-authored-by: Luísa Moura <[email protected]>
Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Scott <[email protected]>
Co-authored-by: Khalil Najjar <[email protected]>

* fix(toolkit): UX/UI improvements (#257)

* Add error troubleshooting (#262)

* Update chat.py

---------

Co-authored-by: Jessica Wu <[email protected]>
Co-authored-by: Khalil Najjar <[email protected]>
Co-authored-by: Luísa Moura <[email protected]>
Co-authored-by: Tomeu <[email protected]>
Co-authored-by: Tianjing Li <[email protected]>
Co-authored-by: misspia-cohere <[email protected]>
Co-authored-by: Eugene P <[email protected]>
Co-authored-by: Scott <[email protected]>
Co-authored-by: Beatrix De Wilde <[email protected]>
Co-authored-by: Alex W <[email protected]>
Co-authored-by: misspia-cohere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtobac tomtobac tomtobac approved these changes

@EugeneLightsOn EugeneLightsOn Awaiting requested review from EugeneLightsOn EugeneLightsOn is a code owner

@malexw malexw Awaiting requested review from malexw malexw is a code owner

@scottmx81 scottmx81 Awaiting requested review from scottmx81

@tianjing-li tianjing-li Awaiting requested review from tianjing-li tianjing-li is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knajjars @tomtobac