Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-create the iPOJO patch #5

Closed
tcalmant opened this issue Apr 2, 2020 · 1 comment
Closed

Re-create the iPOJO patch #5

tcalmant opened this issue Apr 2, 2020 · 1 comment

Comments

@tcalmant
Copy link
Member

tcalmant commented Apr 2, 2020

The version of the iPOJO manipulator included in org.ow2.chameleon.eclipse.ipojo.dependencies is a custom patched version.

The patch has since been lost, but the idea was to modify the java.util.jar.Manifest object right after its create, using java.lang.reflect, to replace an HashMap (undeterministic key order) by a TreeMap (deterministic key order).
This patch ensures that the MANIFEST.MF file won't change if the meaning of its content doesn't.

This issue can be solved 2 ways:

  1. If Upgrade ASM version #4 doesn't involve changes in iPOJO, the patch for the current issue will be added to the repository
  2. If the changes in iPOJO are too large, we'll create a fork and modify it directly.
tcalmant added a commit that referenced this issue Apr 4, 2020
This patch is not necessary since iPOJO 1.8, but the README hasn't been
updated.

Fixes #5
@tcalmant
Copy link
Member Author

tcalmant commented Apr 4, 2020

Path is not necessary since iPOJO 1.8, but the README file in the dependencies plugin folder hadn't been updated.
The issue was solved in FELIX-3131.
The patch is still visible at commit 3f42274

@tcalmant tcalmant closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant