Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPC-H] Configure temporary directory in duckdb for out-of-core processing #1510

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hendrikmakait
Copy link
Member

Closes #1509

@ntabris
Copy link
Member

ntabris commented Apr 24, 2024

This would be a temp directory on the VM? If so, I'd recommend doing something under /scratch so it uses NVMe if present.

@hendrikmakait
Copy link
Member Author

This would be a temp directory on the VM? If so, I'd recommend doing something under /scratch so it uses NVMe if present.

Good point, I'll adjust the code to check if we're running on the cloud. I suppose we should create the temporary directory within the workspace of the Dask worker that runs the coiled.function?

@jrbourbeau
Copy link
Member

I'd recommend doing something under /scratch so it uses NVMe if present

TIL, thanks @ntabris. Is there a way I can figure out when NVMe is present? Is it only specific instance types?

@ntabris
Copy link
Member

ntabris commented Apr 24, 2024

I suppose we should create the temporary directory within the workspace of the Dask worker that runs the coiled.function?

Yeah, that would work—dask worker workspace is already set to be in /scratch.

Is there a way I can figure out when NVMe is present? Is it only specific instance types?

It's specific instance types on AWS, in particular, instance types with d in the family, such as m6id or g4dn (plus a few others, such as g5 which does have NVMe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is duckdb out-of-core processing properly enabled?
3 participants