Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest.skip after cgroups / memory_limit went live on Coiled prod #256

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Aug 18, 2022

These tests should be fixed by coiled/feedback#185

  • test_tensordot_stress
  • test_repeated_merge_spill

The other test test_climatic_mean may require more tuning but I wanted to give it a try, see #253

@fjetter fjetter changed the title Remove pytest.skip Remove pytest.skip after cgroups / memory_limit went live on Coiled prod Aug 18, 2022
@fjetter
Copy link
Member Author

fjetter commented Aug 18, 2022

Ok, test_climatic_mean is definitely still failing. too bad

@gjoseph92
Copy link
Contributor

Not surprised by test_climatic_mean. I still think that's a combination of root task overproduction and mysterious scheduler slowdown.

@crusaderky crusaderky self-assigned this Dec 13, 2022
@crusaderky
Copy link
Contributor

There's an unrelated CI failure in test_tensordot_stress, caused by test_spill: dask/distributed#7398

grafana for test_tensordot_stress:
Screenshot from 2022-12-13 16-41-42

@crusaderky crusaderky merged commit 6657b75 into main Dec 13, 2022
@crusaderky crusaderky deleted the remove_skip_cgroups branch December 13, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants