Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose on_error in to_snowflake #50

Closed
wants to merge 0 commits into from
Closed

Conversation

nick-amplify
Copy link
Contributor

Hey Dask team,

Our team needed to use the on_error arg of write_pandas for our app, so I added it in here.

Lmk what steps I can/should follow to merge this into the official package!

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nick-amplify. Adding support for this seems reasonable to me. However, instead of making on_error= a top-level kwarg, I think I'd rather add a write_pandas_kwargs= argument (similar to the existing connection_kwargs= parameter) that we can use to forward keywords to the write_pandas(...) call we make. So something like

to_snowflake(df, ..., write_pandas_kwargs={"on_error": "SKIP_FILE"})

@nick-amplify
Copy link
Contributor Author

@jrbourbeau hey James! been awhile... but I got back around to this! changed to write_pandas_kwargs and the tests are passing!

@jrbourbeau
Copy link
Member

I tried to merge main (where some test failures have been fixed) and push to this branch, but that somehow closed this PR...

Sorry about that @nick-amplify. I opened up #57 which has the same commits. Hope that's okay

@nick-amplify
Copy link
Contributor Author

I tried to merge main (where some test failures have been fixed) and push to this branch, but that somehow closed this PR...

Sorry about that @nick-amplify. I opened up #57 which has the same commits. Hope that's okay

Yeah that's cool with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants