Introduce Deltalake #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Thanks @mrocklin I'll try this out and try to get it running on the cloud as well
generate_data.py
Outdated
Comment on lines
38
to
40
| else: | ||
| path = pathlib.Path(path) | ||
| path.mkdir(parents=True, exist_ok=True) |
There was a problem hiding this comment.
Hmm I'm curious why this is needed given the mkdir calls later in this function, but I'll probably find out while running this code locally. Feel free to fill me in if you recall why this was added
There was a problem hiding this comment.
This might just be a merge issue.
|
@mrocklin I'm stepping away for a bit but will circle back here. Just pushed commits that resolve merge conflicts and make this run on S3 (and local still) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work yet. I'm getting odd column errors in the tpch query. Sharing early in case people have thoughts.