Update data directory structure #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
commented
Feb 26, 2024
| ) | ||
| generate.fn.client.restart() | ||
| generate.fn.client.restart(wait_for_workers=False) |
There was a problem hiding this comment.
This is an unrelated bugfix for running locally (xref dask/distributed#8534)
Comment on lines
-34
to
-48
|
|
||
| if str(path).startswith("s3://"): | ||
| session = botocore.session.Session() | ||
| creds = session.get_credentials() | ||
| con.install_extension("httpfs") | ||
| con.load_extension("httpfs") | ||
| con.sql( | ||
| f""" | ||
| SET s3_region='{REGION}'; | ||
| SET s3_access_key_id='{creds.access_key}'; | ||
| SET s3_secret_access_key='{creds.secret_key}'; | ||
| SET s3_session_token='{creds.token}'; | ||
| """ | ||
| ) | ||
|
|
There was a problem hiding this comment.
This is unrelated to the directory structure. We don't need to do this configuration because we're not reading / writing with duckdb.
Comment on lines
+1
to
+6
| # Whether to run data-processing tasks locally | ||
| # or on the cloud with Coiled. | ||
| local: true | ||
| # Output location for data files. Can be a local directory | ||
| # or a remote path like "s3://path/to/bucket". | ||
| data-dir: ./data |
There was a problem hiding this comment.
Moving this configuration out into a standalone file (related to, but doesn't close, #2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the data directory structure a bit to something like this: