Initialize variables for presolve to prevent MSVS error C4703 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially uninitialized local pointer variable used for flags, maxdown and maxup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for error/warning C4703 for MSVS builds: Potentially uninitialized local pointer variable used for flags, maxdown and maxup.
The original code initializes flags, maxdown and maxup only "if(takeOutSome)", and only uses these variables under the same condition (good). Unfortunately, the MSVS linker still believes this is potentially wrong--which is incorrect. Due to other linker options (/sdl), these (erroneous) warnings are treated as errors and therefore stop the build. The easiest way to workaround this is to initialize the variables.