Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce addresses and assets params, and some pixel class cleanup #283

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Introduce addresses and assets params, and some pixel class cleanup #283

merged 5 commits into from
Jun 12, 2024

Conversation

steveviselli-cb
Copy link
Contributor

Description & motivation

  • Added new addresses and assets initialization parameters to simplify destinationWallets
  • Marked the destinationWallets initialization parameter as deprecated
  • Added warning message about upcoming deprecation of the embedded experience
  • Simplified the CoinbasePixel class to improve widget initialization latency
  • Fix example code in README

Testing & documentation

  • Unit tests
  • Local testing

@steveviselli-cb steveviselli-cb marked this pull request as ready for review June 11, 2024 22:30
@steveviselli-cb steveviselli-cb merged commit b0cae21 into main Jun 12, 2024
26 checks passed
@steveviselli-cb steveviselli-cb deleted the steve-viselli/addresses branch June 12, 2024 16:22
@OKEAMAH OKEAMAH mentioned this pull request Aug 1, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumxu96 sumxu96 sumxu96 approved these changes

@zack-winchell-cb zack-winchell-cb zack-winchell-cb approved these changes

@patricktruong-cb patricktruong-cb patricktruong-cb approved these changes

@neelramachandran-cb neelramachandran-cb Awaiting requested review from neelramachandran-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steveviselli-cb @sumxu96 @zack-winchell-cb @patricktruong-cb