Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make register-basename.js Quickstart Template Executable #286

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: Make register-basename.js Quickstart Template Executable #286

merged 1 commit into from
Oct 8, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Make the quickstart-templates/register-basename.js executable

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Oct 8, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase merged commit 3b514fd into master Oct 8, 2024
6 checks passed
@John-peterson-coinbase John-peterson-coinbase deleted the hotfix-basename-registration-quickstart-template-execute branch October 8, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase