Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove syncer and reconciler #18

Merged
merged 2 commits into from
May 12, 2020
Merged

Remove syncer and reconciler #18

merged 2 commits into from
May 12, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 12, 2020 •
edited
Loading

Motivation

The syncer and reconciler packages are not usable externally. These packages could be extremely useful to some other projects.

Solution

@patrick-ogrady patrick-ogrady mentioned this pull request May 12, 2020
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 922

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+25.3%) to 74.779%
Totals Coverage Status
Change from base Build 911: 25.3%
Covered Lines: 338
Relevant Lines: 452
💛 - Coveralls

@patrick-ogrady patrick-ogrady assigned annieke and unassigned annieke May 12, 2020
@patrick-ogrady patrick-ogrady merged commit 5a24976 into master May 12, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/migrate-syncer-reconciler branch May 12, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annieke annieke annieke approved these changes

@niallo niallo Awaiting requested review from niallo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @annieke