Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v1.4.0 of the Rosetta API Specification #56

Merged
merged 4 commits into from
Jul 15, 2020
Merged

Add support for v1.4.0 of the Rosetta API Specification #56

merged 4 commits into from
Jul 15, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 15, 2020 •
edited
Loading

Fixes coinbase/mesh-sdk-go#65.
Fixes #54.

Changes

  • Add support for v1.4.0 of the Rosetta API Specification (in rosetta-sdk-go version >v0.3.0)
  • Provide ability to specify inactive reconciliation frequency for accounts using the --inactive-reconciliation-frequency flag
  • Improve ExemptFunc performance

@patrick-ogrady patrick-ogrady changed the title Patrick/v1.4.0 support Add support for v1.4.0 of the Rosetta API Specification Jul 15, 2020
@patrick-ogrady
Copy link
Contributor Author

CircleCI jobs not being kicked off 😞

@patrick-ogrady
Copy link
Contributor Author

image
and now we wait

@patrick-ogrady patrick-ogrady added this to the v0.3.0 release milestone Jul 15, 2020
@coveralls
Copy link

coveralls commented Jul 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1463

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-14.7%) to 60.641%
Totals Coverage Status
Change from base Build 1427: -14.7%
Covered Lines: 416
Relevant Lines: 686
💛 - Coveralls

@patrick-ogrady patrick-ogrady mentioned this pull request Jul 15, 2020
Closed
@patrick-ogrady
Copy link
Contributor Author

patrick-ogrady commented Jul 15, 2020 •
edited
Loading

image

Coverage fell significantly because this PR adds the first test in /internal/processor (it appears Coveralls gives a directory perfect coverage if there are no tests 😞 ).

To avoid bloating this PR, I'm going to punt on writing a ton of tests right now unrelated to any code changes here.

@patrick-ogrady
Copy link
Contributor Author

patrick-ogrady commented Jul 15, 2020 •
edited
Loading

I amended a commit to fix the license issue but Github also appears to be having issues:
image

@patrick-ogrady
Copy link
Contributor Author

Finally!

@patrick-ogrady patrick-ogrady merged commit 3c809c2 into master Jul 15, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/v1.4.0-support branch July 15, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliankoh juliankoh juliankoh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.3.0 release
3 participants
@patrick-ogrady @coveralls @juliankoh