add logger for insufficiently funded accounts during construction #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfl92
approved these changes
Mar 30, 2021
septerr
approved these changes
Mar 30, 2021
lenny-hardenberg
deleted the
add-insufficient-funds-logging-in-construction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When running Rosetta CLI
check:constructionwe might run into an infinite loop without any clear logs that tell us why we are in a loop. Specifically, this might happen when we are looking for a wallet/account with a certain balance, but none of ourprefunded_accountshave sufficient funds.Solution
Log "[number] account(s) insufficiently funded. Did you forget to fund? [list of addresses]" whenever we call
find_balanceand we are unable to match any balance.