Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a validation config for validating operation using rosetta-cli #326

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Introduce a validation config for validating operation using rosetta-cli #326

merged 3 commits into from
Aug 23, 2021

Conversation

shrimalmadhur
Copy link
Contributor

Fixes # .

Motivation

There are lots of validation rosetta-cli doesn't perform on operation.
Few of them include

  • validating that deposit and withdraw balances
  • issuers might want to validate the number of operation for payment or fee

Solution

We introduce a validation config file which an asset issuer can specify and provide as an argument while doing check:data (more to come on how to use)

TODO:

  • Add more tests
  • Figure out how to release the package so that it doesn't break existing usage

Open questions

@coveralls
Copy link

coveralls commented Aug 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 14925

  • 58 of 62 (93.55%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 77.844%
Changes Missing Coverage Covered Lines Changed/Added Lines %
asserter/asserter.go 25 27 92.59%
asserter/block.go 32 34 94.12%
Totals Coverage Status
Change from base Build 14909: 0.2%
Covered Lines: 8499
Relevant Lines: 10918
💛 - Coveralls

@shrimalmadhur shrimalmadhur marked this pull request as ready for review August 20, 2021 21:45
xiaying-peng
xiaying-peng approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@xiaying-peng xiaying-peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shrimalmadhur shrimalmadhur merged commit f1f9fd4 into master Aug 23, 2021
@shrimalmadhur shrimalmadhur deleted the madhur/validation-object branch August 23, 2021 21:16
@IanCFinAG IanCFinAG mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaying-peng xiaying-peng xiaying-peng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrimalmadhur @coveralls @xiaying-peng