Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty inactive queue correctly #68

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Handle empty inactive queue correctly #68

merged 2 commits into from
Jul 16, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 16, 2020 •
edited
Loading

Fixes #67

Changes

Fix a panic in the reconciler when attempting to access an element in an empty array. This regression was introduced in #66.

Future PR

INCREASE TEST COVERAGE

@patrick-ogrady patrick-ogrady changed the title Handle empty inactive queue correctly [WIP] Handle empty inactive queue correctly Jul 16, 2020
@patrick-ogrady patrick-ogrady changed the title [WIP] Handle empty inactive queue correctly Handle empty inactive queue correctly Jul 16, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2565

  • 0 of 15 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 64.535%
Changes Missing Coverage Covered Lines Changed/Added Lines %
reconciler/reconciler.go 0 15 0.0%
Totals Coverage Status
Change from base Build 2549: -0.2%
Covered Lines: 1867
Relevant Lines: 2893
💛 - Coveralls

yfl92
yfl92 approved these changes Jul 16, 2020
View reviewed changes
Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-ogrady patrick-ogrady merged commit 3d021f5 into master Jul 16, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/reconciler-panic branch July 16, 2020 02:34
@patrick-ogrady patrick-ogrady mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in Reconciler
3 participants
@patrick-ogrady @coveralls @yfl92