Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix responsiveness on the new landing page #1496

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mindapivessa
Copy link
Contributor

@mindapivessa mindapivessa commented Oct 24, 2024

What changed? Why?

  • ComponentPreview: Implemented fixed width and adjust how the content overflow for responsiveness.
  • SwapDemo: Assigned width for breakpoints for responsiveness
  • Tweets: Adjusted the width of the cards for responsiveness

Acceptance criteria

  • Users can view component and code blocks decently (nothing gets cut off in an awkward way)
  • Users can scroll horizontally and vertically to view overflow content
  • Copying and components preview should still work E2E (apart from Swap and Checkout)

Notes to reviewers

  • Used magic numbers as a fix because using w-full didn't work. In our next improvement, will find a more elegant way to address this.
  • Some code blocks are indented weirdly and should be addressed with syntax highlighting as a fast follow.
  • @alissacrane-cb could we follow up on this and replacing the checkout button with a fake button that triggers a modal like what we have on the template?

How to test

How has it been tested?

Screen.Recording.2024-10-24.at.1.41.22.AM.mov

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 5:45am
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 5:45am

Copy link

vercel bot commented Oct 24, 2024

Someone is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant