Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "export" option from build #262

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Remove "export" option from build #262

merged 7 commits into from
Oct 19, 2021

Conversation

colbyfayock
Copy link
Owner

Including next export in the build command prevents some features from working out of the box with this starter. Particularly Netlify being able to use its plugin to provide Next.js features like ISR.

Fixes #261

@colbyfayock
Copy link
Owner Author

hey @GuilleAngulo mind giving me your thoughts on this?

@colbyfayock
Copy link
Owner Author

this seemed to deploy fine here but having an issue after cloning the project to see if isr would work so debugging that

@colbyfayock
Copy link
Owner Author

image

issue with node-canvas node version

@colbyfayock
Copy link
Owner Author

okay, added an .nvmrc file so that when netlify picks up the deploy, it will use node 12. this will allow node-canvas to work

i think we should reassess that dependency on node-canvas and explore other options like we were talking about before

don't want to be stuck on node 12, but unsure why it's doing that 🤷

@colbyfayock
Copy link
Owner Author

last comment 😂 i deployed with the revalidate flag on a cloned version of the project and it deployed for me! however, there is a caveat that isr may not work?

10:04:13 PM: Warning: It looks like you're using the 'revalidate' flag in one of your Next.js pages. Please read our docs about ISR on Netlify: https://ntl.fyi/next-isr-info

the link there is broken though

but at least Next.js features should now generally work

@colbyfayock colbyfayock mentioned this pull request Oct 19, 2021
Closed
GuilleAngulo
GuilleAngulo reviewed Oct 19, 2021
View reviewed changes
README.md Outdated
* [Essential Next.js Plugin](https://github.com/netlify/netlify-plugin-nextjs) (recommended)
* [Exporting the project](https://nextjs.org/docs/advanced-features/static-html-export) via `next export`

**Essential Next.js Plugin** should be provided as an option when you're first importing a project based on this starter. If it's not, you can install this plugin using the Netlify Plugins directory. This will allow Netlify to take full advantage of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, I think the last part of the sentence is missing here

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ haha thanks for catching that

@GuilleAngulo
Copy link
Collaborator

I think it makes totally sense, i'll try to deploy as well to test it

@colbyfayock colbyfayock merged commit 7997014 into main Oct 19, 2021
@colbyfayock colbyfayock deleted the main+export branch October 19, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuilleAngulo GuilleAngulo GuilleAngulo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployments to Netlify should use Essential Next.js plugin with full feature set
2 participants
@colbyfayock @GuilleAngulo