Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifically exclude flake8>=6 #537

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Specifically exclude flake8>=6 #537

merged 1 commit into from
Nov 30, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 30, 2022

colcon/ci#11 worked fine for the rest of the colcon repositories, but colcon-core also performs a bootstrap test which is having this same problem. Rather than employ another constraints.txt, it's easier and more correct to express the constraint in the dependency itself.

...until we come up with a long-term solution, that is.

@cottsay cottsay added the bug Something isn't working label Nov 30, 2022
@cottsay cottsay self-assigned this Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 81.51% // Head: 81.51% // No change to project coverage 👍

Coverage data is based on head (c0e8c6d) compared to base (ac820e2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files          59       59           
  Lines        3381     3381           
  Branches      656      656           
=======================================
  Hits         2756     2756           
  Misses        579      579           
  Partials       46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cottsay cottsay added this to the 0.11.1 milestone Nov 30, 2022
@cottsay cottsay merged commit 2710af8 into master Nov 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the cottsay/flake8v6 branch November 30, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants